-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: commitlint docker image isn't tagged with latest/version #3671
Comments
@kaiehrhardt you wanna tackle this? 😊 |
@escapedcat We have to publish a new version (tag). https://github.com/conventional-changelog/commitlint/blob/master/.github/workflows/container-build.yml#L32 @Clockwork-Muse For now, you could go with the edge tag (==master). |
Sorry I'm not (yet) familiar with this. Should/can we do this manually (via dockerhub) now? I assume we can add a latest tag here?
Is says "It will be generated by default (auto mode) for: [...]". But in our case it's not being created by default, right? Do we want to change this?
Happy for a PR |
For my understanding, @kaiehrhardt will the current configuration, will this set the IMO I don't think it's a good idea to set @escapedcat I think all you need to-do is publish a new release tag, I think you use lerna |
accurately described :) Keep the issue open, i will add some container related docs to be more precisely. |
So now the docker image is using the latest commit on master instead of the last official released version? Sorry, but missing some understanding here for now.
Thanks for your work @kaiehrhardt |
yes, with the shared tag
yes. we could change this behaviour if we want to. This is a pattern which is mainly used for security fixes of the base image.
It may happen that these images diverge.
|
If that's how most people use it I'm good with that, thanks. Regarding a new latest tag just for sake of this image I would rather skip this for now and the first official latest tag would than be when we merge and release: #3644 |
@escapedcat can we not push out a patch version before we go to the next major version. I think changing too much at once will be harder to debug if things go wrong. |
Sure, alright, will do within the next days |
This is what I was trying to get at. I don't know what your release schedule is at, though...
Yeah, once I figured out there wasn't a |
Released https://github.com/conventional-changelog/commitlint/releases/tag/v17.7.2 Looks like we got a latest |
Yup, that should do it. |
Yay, you're free to close this issue. Thanks everyone! |
Expected Behavior
That a fully tagged docker image is available, with a version tag and the
latest
tag.Current Behavior
The CI documentation now includes the following:
(Just merged yesterday, thank you!)
... however as of this writing the available tags are:
Which means that the version/latest tags aren't present.
Affected packages
Possible Solution
If my reading of the github actions is correct, performing a release/making a tag should kick off the required CI run and publish the required tags.
Steps to Reproduce
`docker pull registry.hub.docker.com/commitlint/commitlint:latest`
Context
I'm trying to set up an Azure DevOps pipeline, focusing on using container images, because trying to do it via node/npx doesn't seem to be working.
Unfortunately AzDO requires images generally not have an
ENTRYPOINT
entry, which prevents the image from running as-is.(And a few other restrictions, but the image should meet them otherwise)
commitlint --version
N/A
git --version
N/A
node --version
N/A
The text was updated successfully, but these errors were encountered: