-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: minimum node version v18 #3644
Conversation
07e8e23
to
2c11d37
Compare
@escapedcat sounds good to me, the only thing I want to call out is with my pull request that I also updated @types/node, but it was to a lesser version than what's bumped up here. Just want to make sure this version bump wins when my pull request changes are re-applied. |
Thanks for the heads up. Good point. |
14cb9ea
to
6bd4f64
Compare
@escapedcat is this still ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM a couple of questions, also have we checked the docker images build. I think it could be worth a rebase to test that build.
Yeah, will take a look within the next days. Bit busy currently. |
|
BREAKING CHANGE: drop node v14 and v16 support
BREAKING CHANGE: drop TS v4 support
51bd34d
to
32a513d
Compare
BREAKING CHANGE: drop node v14 and v16 support
v16 is almost EOL as well: https://github.com/nodejs/release#release-schedule
This will be merged in September 2023.
#3633 can be re-applied after. @joberstein wdyt?