Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency conventional-changelog-angular to v7 #3690

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 8, 2023

Mend Renovate logo banner

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
conventional-changelog-angular (source) 6.0.0 -> 7.0.0 age adoption passing confidence
conventional-changelog-angular (source) ^6.0.0 -> ^7.0.0 age adoption passing confidence

Release Notes

conventional-changelog/conventional-changelog (conventional-changelog-angular)

v7.0.0: conventional-changelog-conventionalcommits: v7.0.0

Compare Source

⚠ BREAKING CHANGES
  • Node >= 16 is required
  • Now all presets are exports preset config factory function. conventional-changelog-preset-loader now exports new loadPreset and createPresetLoader functions. If you are using presets indirectly, using preset name, no any changes in configuration needed, just upgrade packages to latest versions.
Features

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@escapedcat escapedcat mentioned this pull request Oct 8, 2023
1 task
@renovate renovate bot force-pushed the renovate/conventional-changelog-angular-7.x branch 4 times, most recently from 1c6fcc3 to 0d52fda Compare October 25, 2023 09:01
@renovate renovate bot force-pushed the renovate/conventional-changelog-angular-7.x branch from 0d52fda to 17ce0e1 Compare November 10, 2023 05:11
* chore: update dependency conventional-changelog-angular to v7

* fix: update conventional-changelog-angular unit tests

* fix: improve scope-enum unit tests

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Copy link
Contributor Author

renovate bot commented Nov 18, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@escapedcat
Copy link
Member

⚠ BREAKING CHANGES

Node >= 16 is required

This won't break things for current users, because minimum version for commitlint is already v18.

Now all presets are exports preset config factory function. conventional-changelog-preset-loader now exports new loadPreset and createPresetLoader functions. If you are using presets indirectly, using preset name, no any changes in configuration needed, just upgrade packages to latest versions.

This might break things for current users if they use this functionality? If so it would also be a breaking change for commitlint, right?

/cc @silversonicaxel and @joberstein

@joberstein
Copy link
Contributor

@escapedcat I think it may not be breaking since commitlint isn't using that preset-loader package directly anywhere (see conventional-changelog/index.js here: https://github.com/conventional-changelog/conventional-changelog/pull/1045/files#diff-36b46ae0567b131b3e1b1f3502c0532ee0f66acdfd9857a56994fd3b597e5303 )

But probably worth testing out with a custom parser preset and 'conventional-changelog-angular' in a commitlint config.

@escapedcat
Copy link
Member

Hm, how about merging, releasing and see what happens? :P
If there's an issue, people will complain and it could be rolled back and done with a breaking change. Like we did before :D

@silversonicaxel
Copy link
Contributor

I will be your first tester :)

@escapedcat escapedcat merged commit e234ccb into master Nov 21, 2023
4 checks passed
@escapedcat escapedcat deleted the renovate/conventional-changelog-angular-7.x branch November 21, 2023 02:26
@escapedcat
Copy link
Member

Thanks @silversonicaxel and @joberstein !

@escapedcat
Copy link
Member

https://github.com/conventional-changelog/commitlint/releases/tag/v18.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants