Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dependency @types/node to v20.5.1 #3653

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 21, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/node (source) 20.4.7 -> 20.5.1 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@escapedcat escapedcat merged commit cd8b775 into master Aug 21, 2023
5 checks passed
@escapedcat escapedcat deleted the renovate/node-20.x branch August 21, 2023 04:02
@zWingz
Copy link

zWingz commented Sep 27, 2023

Why update to version 20 ?

@escapedcat
Copy link
Member

Hm? Why not it's. It's just internal types, no?

@zWingz
Copy link

zWingz commented Sep 27, 2023

@escapedcat But the engines just need v14
image

@escapedcat
Copy link
Member

Do you have an issue with it? Should it always match the exact version?
We're preparing a node version upgrade here btw: #3644

@zWingz
Copy link

zWingz commented Sep 27, 2023

There are not issue. I'm just wondering why mine @types/node was upgraded to version 20. And I found commitlint/load dep the @types/node@20..

@escapedcat
Copy link
Member

@zWingz you wanna create a PR to align all types to the currently used nodejs version? In the future we will keep these aligned.

Also see this comment: #3644 (comment)
Maybe we do not need those in some packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants