-
Notifications
You must be signed in to change notification settings - Fork 934
fix: break .cjs after upgrading to 18.4.0 #3754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Downgrade to 17.8.1, it works. But 18.0.0 or 18.1.0 not working. |
@recallwei what version of cosmiconfig are you using? |
![]() {
"dependencies": {
"@baronha/ting": "^1.1.0",
"@hookform/resolvers": "^3.3.2",
"@react-native-async-storage/async-storage": "^1.19.5",
"@react-native-community/cli-platform-android": "^12.0.0",
"@react-native-community/netinfo": "^11.1.0",
"@react-native/gradle-plugin": "0.72.11",
"@react-navigation/bottom-tabs": "^6.5.11",
"@react-navigation/devtools": "^6.0.20",
"@react-navigation/native": "^6.1.9",
"@react-navigation/native-stack": "^6.9.17",
"@tamagui/babel-plugin": "^1.76.0",
"@tamagui/config": "^1.76.0",
"@tamagui/lucide-icons": "^1.76.0",
"@tanstack/react-query": "^5.8.1",
"@types/crypto-js": "^4.2.1",
"appcenter": "^5.0.0",
"appcenter-analytics": "^5.0.0",
"appcenter-crashes": "^5.0.0",
"axios": "^1.6.1",
"crypto-js": "^4.2.0",
"dayjs": "^1.11.10",
"i18next": "^23.7.1",
"lodash": "^4.17.21",
"react": "18.2.0",
"react-hook-form": "^7.48.2",
"react-i18next": "^13.3.2",
"react-native": "0.72.6",
"react-native-code-push": "^8.1.0",
"react-native-gifted-charts": "^1.3.16",
"react-native-linear-gradient": "^2.8.3",
"react-native-reanimated": "^3.5.4",
"react-native-safe-area-context": "^4.7.4",
"react-native-screens": "^3.27.0",
"react-native-svg": "^13.14.0",
"react-native-webview": "^13.6.2",
"rn-flipper-async-storage-advanced": "^1.0.5",
"tamagui": "^1.76.0",
"yup": "^1.3.2",
"zustand": "^4.4.6"
},
"devDependencies": {
"@babel/core": "^7.23.3",
"@babel/preset-env": "^7.23.3",
"@babel/runtime": "^7.23.2",
"@brucesong/eslint-config-react-native": "^0.0.14",
"@commitlint/cli": "^18.4.0",
"@commitlint/config-conventional": "^18.4.0",
"@react-native/metro-config": "^0.74.0",
"@rnx-kit/metro-resolver-symlinks": "^0.1.34",
"@tanstack/eslint-plugin-query": "^5.6.0",
"@tsconfig/react-native": "^3.0.2",
"@types/lodash": "^4.14.201",
"@types/react": "^18.2.37",
"@types/react-test-renderer": "^18.0.6",
"babel-jest": "29.7.0",
"babel-plugin-module-resolver": "^5.0.0",
"commitizen": "^4.3.0",
"cspell": "^8.0.0",
"cz-git": "^1.7.1",
"eslint": "^8.53.0",
"husky": "^8.0.3",
"jest": "29.7.0",
"lint-staged": "^15.0.2",
"metro-react-native-babel-preset": "0.77.0",
"prettier": "^3.0.3",
"react-native-flipper": "0.163.0",
"react-test-renderer": "18.2.0",
"typescript": "5.2.2"
}
} |
Try by removing your .lock file |
@recallwei going to push a fix for this, but if you'd like to address it on your own, change cosmiconfg ^8.0.0 to ^8.2.0 in your lockfile and re-run. |
7 tasks
christophehurpeau
added a commit
to christophehurpeau/pob
that referenced
this issue
Nov 11, 2023
christophehurpeau
added a commit
to christophehurpeau/pob
that referenced
this issue
Nov 11, 2023
It works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Current Behavior
I use .commitlintrc.js, but it only searches for
.mjs
.Affected packages
Possible Solution
No response
Steps to Reproduce
Context
I cannot commit any more with no config change after upgrading to v18.4.0.
commitlint --version
18.4.0
git --version
2.39.3
node --version
v20.9.0
The text was updated successfully, but these errors were encountered: