-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expect newlines in output after linting commit messages #504
Comments
In master we have newline in code. Problem could be in not published package @commitlint/format, cause in npm we have version not from master branch |
@RoyalHunt No, I look into the code of locally installed package, and also found the newline. So I test it in another way, and below is the origin output when I generate a commit: ▶ touch b
▶ git add .
▶ git commit -m "test: 123"
husky > commit-msg (node v10.12.0)
⧗ input: test: 123
✔ found 0 problems, 0 warnings[v1 28bf5c5] test: 123
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 b Redirect the output from stdout into file(but I don't know what is ▶ git reset --soft HEAD^1
▶ git commit -m "test: 123" > out
husky > commit-msg (node v10.12.0)
⧗ input: test: 123
✔ found 0 problems, 0 warnings% and then:
Seems they were output into different stream. |
Adressed via #518 |
When I try to merge more than two branches, commitlint will print its output before git's diff info. Then git will continue to print its output but without a newline.
Current Behavior
Expected Behavior
Affected packages
Possible Solution
Print additional newlines after printing commitlint's output.
Steps to Reproduce (for bugs)
commitlint.config.js
Context
Your Environment
commitlint --version
git --version
node --version
The text was updated successfully, but these errors were encountered: