fix: update dependency cosmiconfig to v8.3.6 - autoclosed

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
cosmiconfig	8.1.3 -> 8.3.6

---

Release Notes

cosmiconfig/cosmiconfig (cosmiconfig)

v8.3.6

Compare Source

Bug Fixes

• ignore search place if accessing it causes ENOTDIR (i.e. if access of a subpath of a file is attempted) (5bd915a)

v8.3.5

Compare Source

Bug Fixes

• pass null to transform function for backwards compat (2b38510)

v8.3.4

Compare Source

Bug Fixes

• remove node: prefix from imports (f76484a), closes #​323

v8.3.3

Compare Source

Bug Fixes

• add back node 14 compat (7392541), closes #​320

v8.3.2

Compare Source

Bug Fixes

• use .cjs extension for sync compiled typescript (0d76a9a)
• use default for async TS loader (5bed3e3)

v8.3.1

Compare Source

Bug Fixes

• do not resolve stopDir when undefined (59082e2), closes #​317

v8.3.0

Compare Source

Features

• add support for TypeScript configuration files (d88b1b4)
• add support for TypeScript configuration files (d88b1b4)
• add support for TypeScript configuration files (a9c7ada)

v8.2.0

Compare Source

• Add support for ECMAScript modules (ESM) to the asynchronous API. End users running Node versions that support ESM can provide .mjs files, or .js files whose nearest parent package.json file contains "type": "module".
  • ${moduleName}rc.mjs and ${moduleName}.config.mjs are included in the default searchPlaces of the asynchronous API.
  • The synchronous API does not support ECMAScript modules, so does not look for .mjs files.
  • To learn more, read "Loading JS modules".

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[escapedcat]

Tried something before here: #3623

[joberstein]

@escapedcat I think I figured this out:

There's an issue with node < 20.8.0 where async/await imports cause a segmentation fault for some reason (got exit code 139 after running the test locally): nodejs/node#40058 (resolved in: nodejs/node#48510 ). It looks like the node 20 check is using node 20.5.x which is why it's failing.

If you look in src/loader.js (https://github.com/cosmiconfig/cosmiconfig/compare/v8.1.3...v8.2.0?short_path=06572a9#diff-e06cc0643d5d32542b35abf16a4c938570ddd0a6d2fb52cc1703b45635e2cb8bR20) you'll notice that the async version of 'loadJs' uses the dynamic import syntax starting in v8.2.0, which aligns with the node issue above. The fix for this was either to instead use the cosmiconfigSync method, or replace all of the js loaders with the sync versions (the js one is the only one actually impacting the tests though since mjs/cjs aren't tested):

const loadJsSync =  defaultLoadersSync['.js'];
...
loaders: {
  '.mjs': loadJsSync,
  '.cjs': loadJsSync,
  '.js': loadJsSync,
  ...
}

Also, the skipped test in load.test.js is failing because the extends in @commitlint/load/fixtures/recursive-extends-ts need to be suffixed with '/index.ts'; require isn't automatically resolving the index.ts as the default path when given the directory. I tried seeing if I could address this with some changes to the commitlint/load tsconfig but didn't have any luck.

[escapedcat]

Wow, nice digging! Thanks @joberstein

It looks like the node 20 check is using node 20.5.x which is why it's failing.

I guess eventually the actions will use 20.8.0 and tests might turn green. That would be great. We can postpone cosmicconfig update till then.

[joberstein]

@escapedcat do you want me to update the JS loaders? It's supposed to be the same functionality, and it would allow support for mjs too in the meantime.

[escapedcat]

@escapedcat do you want me to update the JS loaders? It's supposed to be the same functionality, and it would allow support for mjs too in the meantime.

Sure, happy if you want to give this a try