Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@commitlint/load): Remove unused @types/node dependency #3801

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix(@commitlint/load): Remove unused @types/node dependency #3801

merged 1 commit into from
Nov 29, 2023

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Nov 29, 2023

Description

@commitlint/load has both a regular and dev dependency on @types/node. Only one of these should be needed, and it seems that the regular dependency is not required since the package's API does not rely on these types, so I have removed it. The dev dependency needs to stay as node:path is used in this package.

Motivation and Context

The @types/node dependency could result in multiple major versions of @types/node in a consumer's node_modules, e.g. if a consumer also depends on @types/node@20. This isn't a huge deal, but IMO it's still worth fixing if possible.

Usage examples

N/A

How Has This Been Tested?

The build output (specifically .d.ts files) before and after this change is identical.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat escapedcat merged commit 7b3f8b3 into conventional-changelog:master Nov 29, 2023
4 checks passed
@escapedcat
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants