Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@commitlint/config-nx-scopes): nx 18 support #3907

Merged
merged 1 commit into from
Feb 13, 2024
Merged

chore(@commitlint/config-nx-scopes): nx 18 support #3907

merged 1 commit into from
Feb 13, 2024

Conversation

thengstermanndev
Copy link
Contributor

@thengstermanndev thengstermanndev commented Feb 13, 2024

Description

Add nx 18 support for @commitlint/config-nx-scopes since it's not breaking after the update

Motivation and Context

Package managers are throwing a warning for unmet peer-dependencies.

How Has This Been Tested?

@commitlint/config-nx-scopes is still working after updating Nx to v18

This pull request also closes #3895

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@thengstermanndev
Copy link
Contributor Author

thengstermanndev commented Feb 13, 2024

@escapedcat
/cc @marcin-sieradzki-maersk

Since this is blocking our team from updating the repository i created a new pull request which is also closing #3895. I've already rebased with the latest changes from master branch.

@escapedcat escapedcat merged commit 6f94f58 into conventional-changelog:master Feb 13, 2024
5 checks passed
@escapedcat
Copy link
Member

Thanks, here you go: https://github.com/conventional-changelog/commitlint/releases/tag/v18.6.1

@thengstermanndev
Copy link
Contributor Author

Thanks, here you go: https://github.com/conventional-changelog/commitlint/releases/tag/v18.6.1

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants