Skip to content

feat(rules): add max line length to body/footer #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Fetz
Copy link
Contributor

@Fetz Fetz commented Jul 25, 2018

Description

Allow to add max line length rules to both body and footer

Motivation and Context

fix: https://github.com/marionebl/commitlint/issues/208
enable: https://github.com/marionebl/commitlint/issues/303

Usage examples

// commitlint.config.js
module.exports = {
 rules: {
    'body-max-line-length': [1, 'always', 50],
    'footer-max-line-length': [1, 'always', 50],
  }
};

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Fetz Fetz force-pushed the feature/feat-max-line-length branch from 76fc2b2 to 91e9fc7 Compare July 25, 2018 19:21
@kosssi
Copy link

kosssi commented Aug 10, 2018

@Fetz thanks for your contribution, I search exactly this feature @macklinu can you integrate it ?

kosssi referenced this pull request in cozy/cozy-libs Aug 10, 2018
We would like limit max length of each line, not all body part
We have to wait  to be introduced to commitlint

[See this PR](https://github.com/marionebl/commitlint/pull/400)
kosssi referenced this pull request in cozy/cozy-libs Aug 10, 2018
We would like limit max length of each line, not all body part
We have to wait  to be introduced to commitlint

[See this PR](https://github.com/marionebl/commitlint/pull/400)
kosssi referenced this pull request in cozy/cozy-libs Aug 10, 2018
We would like limit max length of each line, not all body part
We have to wait  to be introduced to commitlint

[See this PR](https://github.com/marionebl/commitlint/pull/400)
@marionebl
Copy link
Contributor

Thanks!

@marionebl marionebl merged commit 542f50e into conventional-changelog:master Aug 20, 2018
@Fetz Fetz deleted the feature/feat-max-line-length branch August 20, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants