-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: show input: from a new line #4102
base: master
Are you sure you want to change the base?
Conversation
This will be less confusing to read, and also easier to test and copy/paste..
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Thanks! I understand that this might be a bit confusing for first time users but this is not a common issue we get. So I would rather close this. It doesn't justify a breaking change. |
@escapedcat this was confusing for 16k users who starred this and will be confusing for a 100k+ more who just don't know what GitHub is. If the confusion if just 5 minutes, it is still worth the output breaking change for me. For integration with editors and stuff, I guess |
Thanks for your feedback. Might be good to open up an issue for this to discuss this further and get some feedback from others. Try searching if we maybe have similiar issues already. Thanks! |
@escapedcat why this issue is not suitable to discuss it? |
Hm, no, it is, but I would prefer you open up an official issue for this to get some feedback/input from other users. |
@escapedcat created #4112 |
This will be less confusing to read, and also easier to test and copy/paste (for example for #4101).
This error log is confusing for people not familiar with
commitlint
.This one should be more clear.
Or maybe even this one.
Motivation and Context
Error output should not mess up original commit message, because it is hard to understand what is wrong.
Usage examples
How Has This Been Tested?
Types of changes
Checklist: