Skip to content

perf(rules): optimize header-trim #4363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025
Merged

perf(rules): optimize header-trim #4363

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf7055c
perf(rules): optimize header-trim
felipecrs Apr 9, 2025
a9f78ce
Simplify other lines
felipecrs Apr 9, 2025
5bc14ee
chore: fix formatting
felipecrs Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions @commitlint/rules/src/header-trim.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,27 +4,19 @@ import { SyncRule } from "@commitlint/types";
export const headerTrim: SyncRule = (parsed) => {
const { header } = parsed;

if (!header) {
return [true];
}
if (!header) return [true];

const startsWithWhiteSpace = header !== header.trimStart();
const endsWithWhiteSpace = header !== header.trimEnd();
const startsWithWhiteSpace = header.length > header.trimStart().length;
const endsWithWhiteSpace = header.length > header.trimEnd().length;

switch (true) {
case startsWithWhiteSpace && endsWithWhiteSpace:
return [
false,
message(["header", "must not be surrounded by whitespace"]),
];
if (startsWithWhiteSpace && endsWithWhiteSpace)
return [false, message(["header", "must not be surrounded by whitespace"])];

case startsWithWhiteSpace:
return [false, message(["header", "must not start with whitespace"])];
if (startsWithWhiteSpace)
return [false, message(["header", "must not start with whitespace"])];

case endsWithWhiteSpace:
return [false, message(["header", "must not end with whitespace"])];
if (endsWithWhiteSpace)
return [false, message(["header", "must not end with whitespace"])];

default:
return [true];
}
return [true];
};