chore!: minimum node version v20

[escapedcat]

Preparing to drop node v18 here

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[escapedcat]

Run yarn build
yarn run v1.22.22
error @commitlint/root@1.0.0: The engine "node" is incompatible with this module. Expected version ">=v20". Got "18.19.1"
error Commands cannot run with an incompatible environment.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

@knocte looks like Ubuntu 24.04 is shipping with node v18?
We usually drop a node version if it's out of maintenance.

But other releases are not LTS.
What's the best way to deal with this?

[escapedcat]

Also tagging @kaiehrhardt @jeohist , sorry!
Happy for feedback.

[JounQin]

What features are we going to use which are only available in Node 20+?

[escapedcat]

What features are we going to use which are only available in Node 20+?

Propably none? We used to switch versions when they ran out of maintenance. Should we not? Can also just leaves this as is for now.

[JounQin]

Personally I'd prefer supporting non LTS versions if there are no efforts required and no new great features we're going to use whenever possible for larger compatibility.

[escapedcat]

Fair enough 👍

[knocte]

Personally I'd prefer supporting non LTS versions

Let's not be ambiguous. You don't mean "let's support non LTS versions", you mean "let's not support LTS versions".

[JounQin]

Let's not be ambiguous. You don't mean "let's support non LTS versions", you mean "let's not support LTS versions".

Your words are as always intense which I don't understand why. >=v18 includes >=v20 what means LTS versions are surely supported. Maybe I mean "let's not only support LTS versions".

[escapedcat]

Sound like we agree with keeping v18 as long as if there's no good reason to upgrade.
I'll leave this as a draft PR.

[knocte]

I believe there is a misunderstanding here. When you mention "LTS" you're probably referring to NodeJS versions. However, I myself was referring to Ubuntu versions.

[knocte]

Sorry, my last 2 replies in this github issue were not really appropiate because I had only read a few comments, but not the ping from @escapedcat . Now I'll reply:

@knocte looks like Ubuntu 24.04 is shipping with node v18?

I have no idea what's Ubuntu's roadmap with regards to upgrading NodeJS in UbuntuLTS versions, but the idea of including the CI job titled "NodeJS installed from stock Ubuntu-LTS packages (not external sources)" was precisely to avoid phasing out NodeJS versions that are still supported in the last LTS version of Ubuntu.

I understand why watching what NodeJS versions are falling out of support is important, but there are people that care more about software releases falling out of support at a distro level (e.g. people that just need NodeJS because it is a dependency of other software they use, but they don't care or know anything about NodeJS). I think commitlint could drop support of old NodeJS versions only when a new Ubuntu LTS version comes out that supports newer NodeJS versions, because if there were security bugs/issues present in the NodeJS version that the last Ubuntu LTS ships, I'm very certain that Canonical would put some effort into backporting the bugfixes or upgrading the NodeJS version altogether.

[escapedcat]

@knocte yup, unerdstood. Thanks for your feedback.
As @JounQin already pointed out, we do not need any new features from nodejs currently.
So we wait for now. I'll just leave this as a draft.