Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): remove old broken husky params fallback #499

Closed
wants to merge 1 commit into from

Conversation

byCedric
Copy link
Member

Description

This removes the commitlint -e $GIT_PARAMS part from commitlint, because this is now failing and probably incompatible with Husky.

Note, I've created two solutions for this problem. This is one, and the other one is to rename. Please pick one, I'll close the other.

Motivation and Context

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@byCedric
Copy link
Member Author

I think I prefer to use #498 because I made it backward compatible.

@marionebl
Copy link
Contributor

Closing in favor of #498

@marionebl marionebl closed this Nov 30, 2018
@byCedric byCedric deleted the bycedric-cli-gitparams-remove branch December 1, 2018 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants