-
Notifications
You must be signed in to change notification settings - Fork 933
refactor: port is-ignored ts #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a6468bd
chore: add ts and jest config
marionebl 6843070
chore: add ts related deps
marionebl 6bc6f46
refactor: port is-ignored to ts
marionebl 243248b
Merge branch 'master' into refactor-port-is-ignored-ts
marionebl dc2eac1
style: apply prettier rules
marionebl df93454
Merge branch 'master' into refactor-port-is-ignored-ts
marionebl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export * from "./lib"; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
module.exports = require('./lib').default; | ||
module.exports.default = module.exports; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module.exports = { | ||
preset: 'ts-jest', | ||
testEnvironment: 'node' | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import semver from 'semver'; | ||
|
||
export type Matcher = (commit: string) => boolean; | ||
|
||
const isSemver = (c: string): boolean => { | ||
const firstLine = c.split('\n').shift(); | ||
|
||
if (typeof firstLine !== 'string') { | ||
return false; | ||
} | ||
|
||
const stripped = firstLine.replace(/^chore(\([^)]+\))?:/, '').trim(); | ||
return semver.valid(stripped) !== null; | ||
}; | ||
|
||
const test = (r: RegExp): ((c: string) => boolean) => r.test.bind(r); | ||
|
||
export const wildcards: Matcher[] = [ | ||
test( | ||
/^((Merge pull request)|(Merge (.*?) into (.*?)|(Merge branch (.*?)))(?:\r?\n)*$)/m | ||
), | ||
test(/^(R|r)evert (.*)/), | ||
test(/^(fixup|squash)!/), | ||
isSemver, | ||
test(/^Merged (.*?)(in|into) (.*)/), | ||
test(/^Merge remote-tracking branch (.*)/), | ||
test(/^Automatic merge(.*)/), | ||
test(/^Auto-merged (.*?) into (.*)/) | ||
]; |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
export * from './is-ignored'; | ||
export {Matcher} from './defaults'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's better, double or single quotes? In other files I see that you are using single, I prefer them too but open for double. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i vote
single
:P