Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(options): add the ability to skip bump/changelog phase by using … #158

Closed

Conversation

denouche
Copy link

…--skip-bump-and-changelog option, and to skip the commit/tag/push phase by using --skip-commit option

closes #157

@denouche denouche force-pushed the feat/157-skip-phases branch from b8983b8 to fc95812 Compare February 23, 2017 09:03
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 97.794% when pulling fc95812 on denouche:feat/157-skip-phases into d0d71a5 on conventional-changelog:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 97.794% when pulling fc95812 on denouche:feat/157-skip-phases into d0d71a5 on conventional-changelog:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 97.794% when pulling fc95812 on denouche:feat/157-skip-phases into d0d71a5 on conventional-changelog:master.

…--skip-bump-and-changelog option, and to skip the commit/tag/push phase by using --skip-commit option

closes conventional-changelog#157
@denouche denouche force-pushed the feat/157-skip-phases branch from fc95812 to ddcc13a Compare February 23, 2017 09:36
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ddcc13a on denouche:feat/157-skip-phases into d0d71a5 on conventional-changelog:master.

1 similar comment
@coveralls
Copy link

coveralls commented Feb 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ddcc13a on denouche:feat/157-skip-phases into d0d71a5 on conventional-changelog:master.

@Tapppi
Copy link
Member

Tapppi commented Feb 23, 2017

Lets wait for the discussion in #157 first, and then decide the fate of this!

@stevemao
Copy link
Member

I like the option, skip-commit, but not the other one :)

@Tapppi
Copy link
Member

Tapppi commented Mar 13, 2017

@stevemao I agree, even if this is not necessary for htis use case once we get started on hooks, it might be worthwile anyway.

@bcoe
Copy link
Member

bcoe commented May 5, 2017

@Tapppi @stevemao @lancecaraccioli I like the idea of enumerating a set of lifecycles that occur in standard-verison:

pre-commit
pre-changelog
pre-tag

...

then it would be neat to allow any of these steps to be skipped within reason -- it would also be nice to try to isolate the logic for each so that, within reason, we can perform a rollback.

@lancecaraccioli
Copy link

lancecaraccioli commented May 5, 2017

@bcoe I was thinking an incremental approach would make sense here. Let's put the infrastructure in place to call hooks first. Then let the community add hooks (via PR) based on their concrete use cases. I'll try to update my PR for #167 today based on discussion there.

Is there a need for to explicitly skip hooks other than just not including it in the package stanza I mean? I may be missing a linking thought on that one.

@bcoe
Copy link
Member

bcoe commented May 14, 2017

@lancecaraccioli @denouche it's looking like the initial hooks work is close to landing; once this is polished with documentation, etc; I think we should then use this as the foundation for adding the support for skipping specific lifecycle hooks.

@bcoe
Copy link
Member

bcoe commented Jun 5, 2017

closing in favor of: #188

@bcoe bcoe closed this Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

How to bump/generate changelog and commit/push in a second time
6 participants