-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(options): add the ability to skip bump/changelog phase by using … #158
feat(options): add the ability to skip bump/changelog phase by using … #158
Conversation
b8983b8
to
fc95812
Compare
2 similar comments
…--skip-bump-and-changelog option, and to skip the commit/tag/push phase by using --skip-commit option closes conventional-changelog#157
fc95812
to
ddcc13a
Compare
1 similar comment
Lets wait for the discussion in #157 first, and then decide the fate of this! |
I like the option, |
@stevemao I agree, even if this is not necessary for htis use case once we get started on hooks, it might be worthwile anyway. |
@Tapppi @stevemao @lancecaraccioli I like the idea of enumerating a set of lifecycles that occur in
... then it would be neat to allow any of these steps to be skipped within reason -- it would also be nice to try to isolate the logic for each so that, within reason, we can perform a rollback. |
@bcoe I was thinking an incremental approach would make sense here. Let's put the infrastructure in place to call hooks first. Then let the community add hooks (via PR) based on their concrete use cases. I'll try to update my PR for #167 today based on discussion there. Is there a need for to explicitly skip hooks other than just not including it in the package stanza I mean? I may be missing a linking thought on that one. |
@lancecaraccioli @denouche it's looking like the initial |
closing in favor of: #188 |
…--skip-bump-and-changelog option, and to skip the commit/tag/push phase by using --skip-commit option
closes #157