Feature/add preid param for semver #83

stvnwrgs · 2016-08-08T09:41:53Z

New argument -p allows you to create prereleases. You can also define a prerelease identifier. via --pre-id="alpha" (beta is default).

stevemao · 2016-08-08T11:30:23Z

index.js

+    default: false,
+    global: true
+  })
+  .option('pre-id', {


I think this should be called "tag", as https://docs.npmjs.com/cli/publish

Also you need to change the final npm publish information

Defining a tag when publishing is the same like a git tag. pre-release and pre-id are one part of the tag. See http://semver.org/ for more infos.

About the publish, yes but this is in the users scope. If you want to use alpha, beta instead of dist-tags f.e, it should be configurable and the user can choose how and where he publishes what. That's one of the great things of standard-version, you can also use if for a non node project.

Where did you see the name "pre-id"?

About the publish, yes but this is in the users scope.

What I mean is just to display a recommendation. Because right now it says npm publish without a tag. Displaying --tag would be a better recommendation.

I'm not completely sure about the relationship between git tag and npm publish tag. It doesn't look the same to me. npm publish by default uses "latest" tag.

Sorry, @stevemao you are right. The npm publish tag is not the same like the git tag. I will also rename it to tag.

stevemao · 2016-08-08T11:31:03Z

I wonder if we could leverage unreleased option in conventional-changelog.

stevemao · 2016-08-08T11:32:04Z

.gitignore

@@ -1,2 +1,3 @@
 node_modules
 .nyc_output
+.idea


Don't do unrelated changes :)

stvnwrgs · 2016-08-10T16:00:58Z

After using it for a while, I found two bugs that need's to be fixed before this can be merged.

One is nearly fixed, the second one needs some discussion.

Should prereleases be shown in the changelog?
I think changelogs should only be written for no prereleases.

feat(args): --next (-x) --actual (-a) now print out the version without doing something

…nd next version

stevemao · 2016-08-10T22:28:50Z

What bugs? Can you remove all unrelated changes and separate different things into different issues?

stvnwrgs · 2016-08-11T07:20:47Z

The bugs should be fixed with the two latest commits. If you tried to create a prerelease and added a new feature, it did not increase the minor version instead, it just increased the prerelease, which was wrong.

The only unrelated thing right now is the next, actual feature. I could remove it, wait until the PR is merged and read it, but its just 15 lines of code. In my opinion, it's not worth the time. But if you insist, I will do it.

Should I remove the changelog entry and downgrade the version to 2.4.0 again?

stevemao · 2016-08-11T07:34:22Z

I'd suggest you to create another PR for other things. You also need to add tests. Also too many unnecessary whitespace changes.

coveralls · 2016-08-11T09:00:12Z

Coverage decreased (-0.9%) to 94.0% when pulling df702f7 on StyleLounge:feature/add-preid-param-for-semver into 0b28a25 on conventional-changelog:master.

stvnwrgs · 2016-08-11T09:06:28Z

@stevemao: What about the package.json and CHANGELOG.md? I think it does not make sense to generate them in the PR, right?

coveralls · 2016-08-11T09:08:29Z

Coverage decreased (-1.3%) to 93.617% when pulling c609595 on StyleLounge:feature/add-preid-param-for-semver into 0b28a25 on conventional-changelog:master.

stevemao · 2016-08-11T10:44:54Z

Yeah, as atomic as possible :)

stvnwrgs · 2016-08-11T13:37:36Z

Should be ready now. Thanks for your help!

coveralls · 2016-08-11T13:42:43Z

Coverage decreased (-1.3%) to 93.617% when pulling 3ad4962 on StyleLounge:feature/add-preid-param-for-semver into 0b28a25 on conventional-changelog:master.

stevemao · 2016-08-11T23:27:07Z

index.js

    checkpoint('bumping version in package.json from %s to %s', [pkg.version, newVersion])
    pkg.version = newVersion
    fs.writeFileSync(pkgPath, JSON.stringify(pkg, null, 2) + '\n', 'utf-8')
  } else {
    checkpoint('skip version bump on first release', [], chalk.red(figures.cross))
  }
-
-  outputChangelog(argv, function () {
+  // only commit the package.json on prerelease


So the version for a prerelease is bumped, but no docs are generated. This only happens when the release is stable. It would flood the changelog otherwise.

See https://github.com/conventional-changelog/conventional-changelog/blob/master/CHANGELOG.md#010-beta3-2015-07-17 it works well for me

@stvnwrgs, I think I'm with @stevemao. Let's generate a CHANGELOG for pre-releases, with this caveat:

It would be neat if there was eventually logic that could once v1.0.0 is released, combine the information from v1.0.2.alpha.0, v1.0.3.alpha.1 into a single v1.0.0 entry in the CHANGELOG; I would start simple though and not have a special case for pre-release handling.

I'm with @bcoe, the end goal should be combining them to a single entry eventually. Another option is to collect the changes in a Unrelease vX.Y.Z and then name it to vX.Y.Z once it's not a pre-release anymore. I could swear I've seen that around, although I'm too lazy now to search for it.

Now that I'm rambling on I realise that this is a result of the workflow, not this change, never mind me.. Anyway for reference:

@bcoe I thought about combining the pre-release logs to a single one, but what about pre-releases containing fixes to other pre-releases. e.g. You do a pre-release of a new feature as v2.1.0-rc.0 with feat(god): can now obtain god powers, but then fix an edge case of this new feature in the next prerelease v2.1.0-rc.1: fix(god): fix edge case to give full god instead of demigod powers. Both of them end up in the combined v2.1.0 changelog and it might end up with quite a lot of changes that are out of context.

stevemao · 2016-08-11T23:33:08Z

README.md

+standard-version -p --tag="<identifier>"
+```
+
+### Dry run


Remove this for this PR?

Why should documentation for new features of a PR not be included?

The code for this is not in this PR yet

stevemao · 2016-08-12T00:05:22Z

I wonder if we should let conventional-recommended-bump to decide if this is a prerelease?

stevemao · 2016-08-12T00:06:40Z

There is also a from-git option in npm-version

stvnwrgs · 2016-08-12T09:46:02Z

Really, after 4 days you come up conventional-recommended-bump ?

stevemao · 2016-08-12T10:17:40Z

What do you mean? I'm just saying if conventional-recommended-bump can detect prereleases

bcoe · 2016-08-20T01:17:35Z

index.js

+      }
+    } else {
+      newVersion = semver.inc(newVersion, 'prerelease', argv.tag)
+      console.log('normal: ' + newVersion)


let's drop this log line.

bcoe · 2016-08-23T05:27:35Z

@stvnwrgs this is awesome work, would love to work with you to get it merged; I've been balancing standard-version with a few other OSS projects, and apologize that the turn around time on our issues can sometimes be moderately frustrating.

Tapppi · 2016-09-17T18:35:58Z

This feature would be awesome. @stvnwrgs do you have interest in continuing work on this, or do you prefer someone else continue if they have time? I intend to review this more thoroughly as soon as I have a slot of time open.

AntJanus · 2016-10-04T16:01:38Z

@Tapppi @stvnwrgs I'd be really interested in seeing this feature pass. What else is left? Maybe I can fork + contribute

stevemao · 2016-10-04T22:47:13Z

@AntJanus you are more than welcome to pick up the work 😄 open source projects are about community 😃

stvnwrgs · 2016-10-05T10:29:08Z

@AntJanus I'm out. Feel free!

bcoe · 2016-10-06T04:50:18Z

@AntJanus I'd love to see this feature too, perhaps you can start by opening an issue; and we can discus what we'd like to see out of pre-release functionality? Then we can help see @stvnwrgs hard work over the finish line.

AntJanus · 2016-10-06T15:06:47Z

@bcoe Opened an issue on #122

bcoe · 2016-11-26T21:09:04Z

closing in favor of #129 which looks almost ready to land.

Steven Wirges added 5 commits August 8, 2016 11:21

chore(gitignore): added .idea

151899d

feat: added support for prereleases

3461c44

docs: added description for prereleases

3cdf230

docs: changed prelrelease channel to identifier

a9d5cef

chore(release): 2.5.0

1ddff3b

stevemao reviewed Aug 8, 2016
View reviewed changes

.gitignore

@@ -1,2 +1,3 @@

node_modules

.nyc_output

.idea

Copy link

Member

stevemao Aug 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do unrelated changes :)

sl-bot added 2 commits August 10, 2016 19:10

fix(prerelease): prerelease know increases the version right

5968d40

feat(args): --next (-x) --actual (-a) now print out the version without doing something

style: fixed indention

bc0a0c6

stvnwrgs mentioned this pull request Aug 10, 2016

Review before commit #80

Closed

doc: changed pre-id to tag and added notes for dry runs with actual a…

2c33ed5

…nd next version

stvnwrgs added 2 commits August 11, 2016 09:40

style: fixed linting problems

348f0df

test: added tests for --pre-release and --next + --actual

df702f7

chore: removed --next and --actual

c609595

chore: resetted package.json and CHANGELOG.md to 2.4.0

3ad4962

stevemao reviewed Aug 11, 2016
View reviewed changes

bcoe reviewed Aug 20, 2016
View reviewed changes

stevemao mentioned this pull request Sep 15, 2016

Support pre release #105

Closed

e-cloud mentioned this pull request Sep 20, 2016

As a replacement of npm version, there is no control with the version? #107

Closed

This was referenced Sep 22, 2016

RC Support #109

Closed

Generate wip changelogs #111

Closed

stevemao mentioned this pull request Oct 4, 2016

Named versions #118

Closed

AntJanus mentioned this pull request Oct 6, 2016

Feature/add preid param for semver #122

Closed

e-cloud mentioned this pull request Oct 15, 2016

support releasing a custom version, including pre-releases #129

Merged

fritzvd mentioned this pull request Oct 17, 2016

How would I make a hotfix/patch release to an older branch/release #130

Open

Tapppi mentioned this pull request Oct 26, 2016

support pre-patch #133

Closed

bcoe closed this Nov 26, 2016

gr00nd mentioned this pull request Feb 5, 2024

[Snyk] Upgrade figures from 3.2.0 to 6.0.1 gr00nd/standard-version#5

Open

Feature/add preid param for semver #83

Feature/add preid param for semver #83

Conversation

stvnwrgs commented Aug 8, 2016

stevemao Aug 8, 2016 • edited Loading

Choose a reason for hiding this comment

stvnwrgs Aug 8, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stvnwrgs Aug 10, 2016 • edited Loading

Choose a reason for hiding this comment

stevemao commented Aug 8, 2016

Choose a reason for hiding this comment

stvnwrgs commented Aug 10, 2016 • edited Loading

stevemao commented Aug 10, 2016

stvnwrgs commented Aug 11, 2016 • edited Loading

stevemao commented Aug 11, 2016

coveralls commented Aug 11, 2016 • edited Loading

stvnwrgs commented Aug 11, 2016

coveralls commented Aug 11, 2016 • edited Loading

stevemao commented Aug 11, 2016

stvnwrgs commented Aug 11, 2016

coveralls commented Aug 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tapppi Oct 5, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevemao commented Aug 12, 2016

stevemao commented Aug 12, 2016 • edited Loading

stvnwrgs commented Aug 12, 2016

stevemao commented Aug 12, 2016

Choose a reason for hiding this comment

bcoe commented Aug 23, 2016

Tapppi commented Sep 17, 2016

AntJanus commented Oct 4, 2016

stevemao commented Oct 4, 2016

stvnwrgs commented Oct 5, 2016

bcoe commented Oct 6, 2016

AntJanus commented Oct 6, 2016

bcoe commented Nov 26, 2016

stevemao Aug 8, 2016 •

edited

Loading

stvnwrgs Aug 8, 2016 •

edited

Loading

stvnwrgs Aug 10, 2016 •

edited

Loading

stvnwrgs commented Aug 10, 2016 •

edited

Loading

stvnwrgs commented Aug 11, 2016 •

edited

Loading

coveralls commented Aug 11, 2016 •

edited

Loading

coveralls commented Aug 11, 2016 •

edited

Loading

coveralls commented Aug 11, 2016 •

edited

Loading

Tapppi Oct 5, 2016 •

edited

Loading

stevemao commented Aug 12, 2016 •

edited

Loading