feat: add greedy whitespace tokenizer #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
reviewed
Dec 25, 2020
| @@ -26,6 +26,14 @@ describe('<message>', () => { | |||
| parsed = parser('feat(http parser)!: add support for scopes') | |||
| parsed.should.matchSnapshot() | |||
| }) | |||
| it('parses summary with multiple spaces after separator', () => { | |||
There was a problem hiding this comment.
I think this change to the parser is great.
Mind updating the grammar in the README too, adding the permissive <whitespace>* marker wherever it's now supported?
There was a problem hiding this comment.
It was already in the grammar actually @bcoe
<summary>may include":", <whitespace>*<footer>may include<separator>, <whitespace>*
The only change I made was switching <continuation> from <whitespace> to <whitespace>+. (requires at least 1 whitespace)
byCedric
force-pushed
the
@bycedric/feat/whitespace
branch
from
d4c8cf7 to
1529eb1
Compare
bcoe
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
whitespaceparsing (as mentioned in #16), it's set (by default) to greedy. I think that's great and here is why:whitespacenode (with exact value ofc)Some good examples
But not too permissive (yet)