feat: support BREAKING CHANGE in body #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
commented
Dec 29, 2020
| <newline> ::= [<CR>], <LF> | ||
| <parens> ::= "(" | ")" | ||
| <ZWNBSP> ::= "U+FEFF" | ||
| <TAB> ::= "U+0009" |
There was a problem hiding this comment.
adding the breaking-change node forced me to indent for consistency.
bcoe
commented
Dec 29, 2020
| | <summary>, <newline>*, <footer>+ | ||
| | <summary>, <newline>* | ||
|
|
||
| /* "!" should be added to the AST as a <breaking-change> node with the value "!" */ |
There was a problem hiding this comment.
Added note that ! should be added as a breaking-change node to the AST (this is already the behavior).
bcoe
commented
Dec 29, 2020
| <text> ::= <any UTF8-octets except newline>* | ||
|
|
||
|
|
||
| <body> ::= [<any body-text except pre-footer>], <newline>, <body>* |
There was a problem hiding this comment.
introduced a <body-text> node, which is <text> with an optional BREAKING CHANGE prefix.
bcoe
commented
Dec 29, 2020
|
|
||
| <body> ::= [<any body-text except pre-footer>], <newline>, <body>* | ||
| | [<any body-text except pre-footer>] | ||
| /* For convenience the <breaking-change>, <separator>, <whitespace>, and |
There was a problem hiding this comment.
Note for implementers that we don't want to add a <body-text> node to the AST.
bcoe
commented
Dec 29, 2020
| | <text> | ||
| <continuation> ::= <newline>, <whitespace>+, <text> | ||
|
|
||
| <breaking-change> ::= "BREAKING CHANGE" | "BREAKING-CHANGE" |
There was a problem hiding this comment.
The text on conventionalcommits.org indicates that we should support BREAKING-CHANGE.
byCedric
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGEnode inbody.BREAKING CHANGE, adding support forBREAKING-CHANGE(See: spec).