Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding start of aws to include instances in solve #5

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Dec 6, 2022

This PR will:

  • add support for adding AWS instances to the solve (see picture below, and yes we need to derive our own descriptions)
    image
  • add plumbing that gets and saves GCP pricing data. Matching these to instances is another thing we will need to think about.
  • Start of pluming for AWS prices, but I don't have correct permissions.
  • Changed output type for asp file to just --asp because that's what I wanted to use

It's been interesting comparing the two APIs - AWS is a lot richer in terms of metadata for instances. I suspect their pricing API might have more transparency but I haven't seen it yet. I'm also doing my best to have shared functionality for the top level classes (e.g., Instance that is base class for GoogleCloudInstance and AmazonInstance).

Anyway, this is good progress! Still a lot to do, but having fun and will get there :) I'm going to chomp off as many of these TODOs as I can on my own, and when I'm ready to share with the group will write up remaining work into more robust TODOs for the group to think about.

Signed-off-by: vsoch vsoch@users.noreply.github.com

vsoch added 2 commits December 5, 2022 17:55
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch vsoch merged commit 5a52791 into main Dec 6, 2022
@vsoch vsoch deleted the add/prices-google-to-solver branch December 6, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant