adding start of aws to include instances in solve #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will:
--asp
because that's what I wanted to useIt's been interesting comparing the two APIs - AWS is a lot richer in terms of metadata for instances. I suspect their pricing API might have more transparency but I haven't seen it yet. I'm also doing my best to have shared functionality for the top level classes (e.g., Instance that is base class for GoogleCloudInstance and AmazonInstance).
Anyway, this is good progress! Still a lot to do, but having fun and will get there :) I'm going to chomp off as many of these TODOs as I can on my own, and when I'm ready to share with the group will write up remaining work into more robust TODOs for the group to think about.
Signed-off-by: vsoch vsoch@users.noreply.github.com