Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad-Hoc command result form not shown #2240

Closed
Zash opened this issue Sep 20, 2020 · 4 comments
Closed

Ad-Hoc command result form not shown #2240

Zash opened this issue Sep 20, 2020 · 4 comments
Labels
bug
Milestone
7.0.1

Comments

@Zash
Copy link
Contributor

Zash commented Sep 20, 2020 •
edited by jcbrand
Loading

Describe the bug (or feature request?)
Ad-hoc commands can consist of multiple steps, as well as return the final results in a dataform. This does not appear to be supported.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings (the ⚙️ button in the control box)
  2. Click on Commands and fill in the address of an entity that exposes a multi-step command or one that returns a form as result.
  3. Run the command.
  4. Observe lack of result form.

Expected behavior
If a command returns a result form, the data in it should be shown.

For multi-step commands, the next form should be shown.

Screenshots

It just shows the first form, no changes.

Environment (please complete the following information):

  • Debian 10 desktop
  • Firefox 68.12.0esr ESR
  • Converse.js version ced4336

Additional context

The Prosody module mod_adhoc_dataforms_demo can be used to test multi-step commands.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@jcbrand jcbrand added the bug label Sep 22, 2020
@jcbrand jcbrand modified the milestone: 7.0.0 Sep 22, 2020
@poVoq
Copy link
Contributor

poVoq commented Oct 6, 2020

Just to add: Biboumi requires a multistep ad-hoc command to set up IRC NICKSERV, thus this would probably be a often used feature.

@jcbrand jcbrand added this to the 7.0.0 milestone Oct 7, 2020
@jcbrand jcbrand modified the milestones: 7.0.0, 7.0.1 Nov 18, 2020
@poVoq
Copy link
Contributor

poVoq commented Dec 13, 2022 •
edited
Loading

Still an issue on the "configure a few settings for that IRC server" adhoc command of Biboumi. I think it is related to the length of the reply. Shorter adhox commands on the same component seem to work.

I just managed to break my Biboumi config by trying to use adhoc commands with ConverseJS.

Edit: fixed in 10.0.0 it seems.

@poVoq
Copy link
Contributor

poVoq commented Dec 13, 2022 •
edited
Loading

In the Firefox browser console I get the following error when and only when I press the buggy command mentioned above:

ERROR: Error while trying to execute command for irc.example.com log.js:64:19
    log log.js:64
    error log.js:81
    toggleCommandForm utils.js:159
    toggleCommandForm adhoc-commands.js:80
    toggleCommandForm adhoc-commands.js:40
    handleEvent lit-html.ts:2047
    (Async: EventListener.handleEvent)
    _$AI lit-html.ts:2036
    m lit-html.ts:1240
    T lit-html.ts:1582
    _$AI lit-html.ts:1434
    S lit-html.ts:1647
    _$AI lit-html.ts:1438
    m lit-html.ts:1240
    T lit-html.ts:1582
    _$AI lit-html.ts:1434
    m lit-html.ts:1240
    T lit-html.ts:1569
    _$AI lit-html.ts:1434
    tu lit-html.ts:677
    update lit-element.ts:165
    performUpdate reactive-element.ts:1302
    scheduleUpdate reactive-element.ts:1234
    _$E_ reactive-element.ts:1206
    requestUpdate reactive-element.ts:1181
    set reactive-element.ts:707
    fetchCommands adhoc-commands.js:61
    fetchCommands adhoc-commands.js:36
    handleEvent lit-html.ts:2047
    (Async: EventListener.handleEvent)
    _$AI lit-html.ts:2036
    m lit-html.ts:1240
    T lit-html.ts:1582
    _$AI lit-html.ts:1434
    tu lit-html.ts:677
    update lit-element.ts:165
    performUpdate reactive-element.ts:1302
    scheduleUpdate reactive-element.ts:1234
    _$E_ reactive-element.ts:1206
    requestUpdate reactive-element.ts:1181
    o reactive-element.ts:923
    Nd reactive-element.ts:906
    _u lit-element.ts:115
    hv element.js:5
    <anonymous> adhoc-commands.js:25
    p lit-html.ts:1181
    T lit-html.ts:1572
    _$AI lit-html.ts:1434
    tu lit-html.ts:677
    render view.js:79
    initialize base.js:28
    initialize user-settings.js:11
    Iv view.js:45
    s helpers.js:32
    s helpers.js:32
    create api.js:46
    show api.js:26
    showUserSettingsModal statusview.js:32
    handleEvent lit-html.ts:2047

And a second one:

 ERROR: 6059/nl.xForm2TemplateResult@https://converse.f-hub.org/dist/converse.min.js:240:391
6059/toggleCommandForm/e.fields<@https://converse.f-hub.org/dist/converse.min.js:1208:1783
6059/toggleCommandForm/<@https://converse.f-hub.org/dist/converse.min.js:1208:1772
async*toggleCommandForm@https://converse.f-hub.org/dist/converse.min.js:1208:1980
toggleCommandForm@https://converse.f-hub.org/dist/converse.min.js:1208:585
handleEvent@https://converse.f-hub.org/dist/converse.min.js:2:400476
EventListener.handleEvent*_$AI@https://converse.f-hub.org/dist/converse.min.js:2:400367
m@https://converse.f-hub.org/dist/converse.min.js:2:396742
T@https://converse.f-hub.org/dist/converse.min.js:2:398056
_$AI@https://converse.f-hub.org/dist/converse.min.js:2:397456
S@https://converse.f-hub.org/dist/converse.min.js:2:398343
_$AI@https://converse.f-hub.org/dist/converse.min.js:2:397502
m@https://converse.f-hub.org/dist/converse.min.js:2:396742
T@https://converse.f-hub.org/dist/converse.min.js:2:398056
_$AI@https://converse.f-hub.org/dist/converse.min.js:2:397456
m@https://converse.f-hub.org/dist/converse.min.js:2:396742
T@https://converse.f-hub.org/dist/converse.min.js:2:398001
_$AI@https://converse.f-hub.org/dist/converse.min.js:2:397456
tu@https://converse.f-hub.org/dist/converse.min.js:2:393438
update@https://converse.f-hub.org/dist/converse.min.js:2:401385
performUpdate@https://converse.f-hub.org/dist/converse.min.js:2:391415
scheduleUpdate@https://converse.f-hub.org/dist/converse.min.js:2:391062
_$E_@https://converse.f-hub.org/dist/converse.min.js:2:390970
async*requestUpdate@https://converse.f-hub.org/dist/converse.min.js:2:390865
set@https://converse.f-hub.org/dist/converse.min.js:2:387584
fetchCommands@https://converse.f-hub.org/dist/converse.min.js:1208:879
async*fetchCommands@https://converse.f-hub.org/dist/converse.min.js:1208:443
handleEvent@https://converse.f-hub.org/dist/converse.min.js:2:400476
EventListener.handleEvent*_$AI@https://converse.f-hub.org/dist/converse.min.js:2:400367
m@https://converse.f-hub.org/dist/converse.min.js:2:396742
T@https://converse.f-hub.org/dist/converse.min.js:2:398056
_$AI@https://converse.f-hub.org/dist/converse.min.js:2:397456
tu@https://converse.f-hub.org/dist/converse.min.js:2:393438
update@https://converse.f-hub.org/dist/converse.min.js:2:401385
performUpdate@https://converse.f-hub.org/dist/converse.min.js:2:391415
scheduleUpdate@https://converse.f-hub.org/dist/converse.min.js:2:391062
_$E_@https://converse.f-hub.org/dist/converse.min.js:2:390970
async*requestUpdate@https://converse.f-hub.org/dist/converse.min.js:2:390865
o@https://converse.f-hub.org/dist/converse.min.js:2:388533
Nd@https://converse.f-hub.org/dist/converse.min.js:2:386861
_u@https://converse.f-hub.org/dist/converse.min.js:2:401033
hv@https://converse.f-hub.org/dist/converse.min.js:2:579836
@https://converse.f-hub.org/dist/converse.min.js:1208:265
p@https://converse.f-hub.org/dist/converse.min.js:2:396313
T@https://converse.f-hub.org/dist/converse.min.js:2:398038
_$AI@https://converse.f-hub.org/dist/converse.min.js:2:397456
tu@https://converse.f-hub.org/dist/converse.min.js:2:393438
render@https://converse.f-hub.org/dist/converse.min.js:22:1480
initialize@https://converse.f-hub.org/dist/converse.min.js:22:4216
initialize@https://converse.f-hub.org/dist/converse.min.js:1617:116
6059/Iv<@https://converse.f-hub.org/dist/converse.min.js:22:1106
6059/zi/s<@https://converse.f-hub.org/dist/converse.min.js:2:292536
6059/zi/s<@https://converse.f-hub.org/dist/converse.min.js:2:292536
create@https://converse.f-hub.org/dist/converse.min.js:165:1058
show@https://converse.f-hub.org/dist/converse.min.js:165:969
showUserSettingsModal@https://converse.f-hub.org/dist/converse.min.js:1640:582
handleEvent@https://converse.f-hub.org/dist/converse.min.js:2:400476
log.js:64:19

@poVoq
Copy link
Contributor

poVoq commented Dec 19, 2022

Actually the Biboumi issue I have mentioned above seems to be fixed in 10.0.0.

I was still testing with an outdated 9.1.1. without noticing.

jcbrand added a commit that referenced this issue Feb 13, 2023
@jcbrand
Add-hoc form fixes
f6890db 
- Provide actions as received in the Ad-Hoc form
- Add support for multi-stage ad-hoc forms

Fixes #2240
jcbrand added a commit that referenced this issue Feb 14, 2023
@jcbrand
Add-hoc form fixes
59e10b9 
- Provide actions as received in the Ad-Hoc form
- Add support for multi-stage ad-hoc forms
- Add new tests for multi-stage forms

Fixes #2240
jcbrand added a commit that referenced this issue Feb 14, 2023
@jcbrand
Add-hoc form fixes
41de70e 
- Provide actions as received in the Ad-Hoc form
- Add support for multi-stage ad-hoc forms
- Add new tests for multi-stage forms

Fixes #2240
jcbrand added a commit that referenced this issue Feb 14, 2023
@jcbrand
Add-hoc form fixes
2323f4a 
- Provide actions as received in the Ad-Hoc form
- Add support for multi-stage ad-hoc forms
- Add new tests for multi-stage forms

Fixes #2240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
7.0.1
Development

No branches or pull requests
3 participants
@Zash @jcbrand @poVoq