Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes, only the first line URL is linkified #2870

Closed
licaon-kter opened this issue Apr 7, 2022 · 10 comments
Closed

Quotes, only the first line URL is linkified #2870

licaon-kter opened this issue Apr 7, 2022 · 10 comments

Comments

@licaon-kter
Copy link
Contributor

licaon-kter commented Apr 7, 2022

4d4e0ff, Firefox Stable
quotedlinks


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@debanjana-a11y
Copy link

debanjana-a11y commented Jul 5, 2022

Hello, I was trying to reproduce this issue in Firefox with a development setup but I cant find "Quote line" feature, can you guide me how to quote lines to reproduce it ?
Is it available for OMEMO encryption only ?

@licaon-kter
Copy link
Contributor Author

Paste this:

> https://nohello.net
> https://xmpp.work

@debanjana-a11y
Copy link

debanjana-a11y commented Jul 5, 2022

Found it on both Firefox and Google Chrome. I want to work on this..

post

@debanjana-a11y
Copy link

debanjana-a11y commented Jul 6, 2022

Hi, I have fixed the issue. But before the fix I was testing with make check without my changes and found test failure from Test 115.
Any idea if this type of failure is already known or only my machine is having these ? I am running in Ubuntu.

error_test

@debanjana-a11y
Copy link

Any suggestion on how to start adding test case for this ? I could test the fix only from browser.

@jcbrand
Copy link
Member

jcbrand commented Jul 9, 2022

Hi @debanjana-a11y, is your work in a branch somewhere where I can take a look?

The styling tests are here:

it("can be styled with quote XEP-0393 message styling hints",

@debanjana-a11y
Copy link

Hi @debanjana-a11y, is your work in a branch somewhere where I can take a look?
Hi, It is here
be6bef8

@debanjana-a11y
Copy link

@jcbrand how to test this individual test cases ? If I write a test case how I'm going to test it ? Like I said above make check causes many test failure in my setup (screenshot above)

Thanks in advance

@debanjana-a11y
Copy link

debanjana-a11y commented Jul 31, 2022

Since some tests were already failing so I have to test my changes with new testcase with all other tests commented and it is working. Please review my changes and let me know if any feedback.

post

jcbrand pushed a commit that referenced this issue Aug 15, 2022
@jcbrand
Copy link
Member

jcbrand commented Aug 15, 2022

I've merged @debanjana-a11y's fix. Thanks!

@jcbrand jcbrand closed this as completed Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants