style: blockquote style and added mixin-icon #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkraav
requested changes
Apr 10, 2020
* `firstUpdated()` is the more semantically logical execution site * `this.menuItemsElements` is well reusable for target scanning
lkraav
reviewed
Apr 12, 2020
lkraav
reviewed
Apr 12, 2020
lkraav
reviewed
Apr 12, 2020
lkraav
reviewed
Apr 12, 2020
lkraav
reviewed
Apr 12, 2020
|
I am getting this error from husky: but unless there's also a class that could be used to select the img, I don't really know how to solve this without forcing husky ignore it. |
…freudFlintstone/aybolit into raphael-cxl-lumo-styles-issue43
|
@lkraav Is this done? |
|
Finally all systemic issues fixed here. @freudFlintstone give the latest |
saas786
pushed a commit
that referenced
this pull request
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Am I missing something? I don't have a material icon mixin anywhere in the cxl-lumo-styles package.
I added an icons.scss file, defined a mixin-icon and added the vaadin quote icon, so I could do the style.
If it's not ok to keep those changes, then I need to know where the original mixin is.