-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fetching of the priority of a validation error type #269
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #269 +/- ##
============================================
+ Coverage 64.71% 64.99% +0.27%
- Complexity 864 866 +2
============================================
Files 134 134
Lines 6723 6725 +2
Branches 789 789
============================================
+ Hits 4351 4371 +20
+ Misses 2074 2055 -19
- Partials 298 299 +1
Continue to review full report at Codecov.
|
@@ -421,6 +422,7 @@ | |||
.field(MapFetcher.field("entity_id")) | |||
.field(MapFetcher.field("entity_sequence", GraphQLInt)) | |||
.field(MapFetcher.field("bad_value")) | |||
.field(ErrorPriorityFetcher.field("error_type_priority")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the intent with the errorCountType
definition below is to contain high-level information about the error type, including the count, english message and priority fields. I think this error priority fetcher should be removed because it's redundant information. Open to hearing a counter argument though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally thought each error needed this info, but after implementing ibi-group/datatools-ui#527 I realized I didn't really need it. So yeah, I'll remove it.
🎉 This PR is included in version 5.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Checklist
dev
before they can be merged tomaster
)Description
This PR will expose the priority level of validation errors through the GraphQL schema. This is needed in order to implement ibi-group/datatools-ui#477.