Allow creating regional analyses with different destination grid extents #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alignment of grids of different sizes is currently disabled due to lack of tests.
Fixes #676 Workers could already handle this. This relaxes a backend validation step to let such analyses through, checking only the zoom level and not the full extents. The zoom level is currently hard-wired so this check will always succeed, we expect to soon allow varying zooms.
ansoncfit
approved these changes
Feb 15, 2021
src/main/java/com/conveyal/analysis/controllers/RegionalAnalysisController.java
Outdated
Show resolved
Hide resolved
src/test/java/com/conveyal/r5/analyst/GridTransformWrapperTest.java
Outdated
Show resolved
Hide resolved
…isController.java Co-authored-by: Anson Stewart <astewart@conveyal.com>
….java Co-authored-by: Anson Stewart <astewart@conveyal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #676. After adding some tests on the GridTransformWrapper, this relaxes restrictions on the backend so analyses with multiple grids of varying extents can be created.