-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feed id column to path results #927
Conversation
Many constants (as indicated by capitalization) were not static. One field always set in the constructor was not final. The list of resultAssemblers WAS static. This may be a remnant of pre- component design. This was not problematic because we never construct more than one Broker, but it should be possible to do (no global state).
This reverts commit f71a72c.
This change adds a new helper method to pass a `fields` object to `MongoMap#findByIdIfPermitted` and utilizes that to exclude modifications while looking up a regional analysis to generate a `scenarioJsonUrl`. This will prevent errors from occurring if custom modifications are used in a worker version that do not exist in the server.
Final and static field modifiers in Broker
As recently discussed: the number of fields will remain fixed. The feed ID field will always be present, but will be empty unless it is intentionally switched on. That is, it won't be automatically enabled even when there are multiple feeds in a bundle. It will be enabled using the "flags" approach demonstrated in #930. I'm starting to wonder though whether this merits a structured CsvOptions in the request:
While we're already considering increasing the hard-wired number of columns, I'd like to suggest adding another empty-by-default field called "label" or "group", which would be used to facilitate filtering and grouping CSV output rows in specialized use cases (such as select-link). |
reverse order of name and ID in output and enum. string flags are maintained in request but no longer used. deleted code serves as example of how to use flags.
keepRoutingOnFoot only in transit access searches
Co-authored-by: Anson Stewart <astewart@conveyal.com>
Co-authored-by: Anson Stewart <astewart@conveyal.com>
Co-authored-by: Anson Stewart <astewart@conveyal.com>
Include names in paths in CSV
…into results-with-feedids
For future use (see #924, for example)
A few comments on the current implementation discussed during the call:
|
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (when looking at the alternate diff view you linked to). I wish I understood better why the default diff ends up looking this way due to a rebase, but hopefully the merge will work correctly.
The merge-base changed after approval.
Superseded by #936 to overcome apparent bad state on the Github side. |
Pull request was closed
This PR addresses #920, adding a column for feedIds to CSV path detail results. It also adds a "group" column to these results, reserved for future use. As noted in the discussion below and in #920, we are deriving the feedId from the boarding stop for convenience; this should generally correspond with the feedId of the route, but it may not (if, for example, a route has been subject to a reroute modification sending it to a stop from a different feed).
Because of some clumsy rebasing, the diff here looks larger than it is. See instead dev...results-with-feedids