Private subnets should only be created when rack is Private #3628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 36.04% // Head: 36.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3628 +/- ##
==========================================
- Coverage 36.04% 36.01% -0.04%
==========================================
Files 168 168
Lines 18536 18536
==========================================
- Hits 6682 6675 -7
- Misses 10717 10725 +8
+ Partials 1137 1136 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yuriadams
approved these changes
Jan 10, 2023
heronrs
approved these changes
Jan 11, 2023
nightfury1204
approved these changes
Jan 17, 2023
Twsouza
added a commit
that referenced
this pull request
Jan 19, 2023
### What is the feature/fix? When the VPC endpoints and the private subnets were removed here #3607, the Timer was still using the SubnetPrivateX in the VPC config, which was blocking any attempt on updating any rack with Timers.  Since the Timers don't use the private subnet anymore, is safe to remove them if the rack is not private. ### Does it has a breaking change? For old racks before `20221202145130` with Timers deployed, they will receive an error while updating the rack (due to the removal of the private subnet). The user must update to `20221202145130`, deploy the Timer again, and then update the rack. ### How to use/test it? Update any rack to the RC, after the update is complete, check on VPC if the private subnet was deleted. For private racks, the private subnet should still exist. ### Checklist - [ ] New coverage tests - [x] Unit tests passing - [x] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [x] No warnings or errors on Deepsource/Codecov
Twsouza
added a commit
that referenced
this pull request
Jan 26, 2023
### What is the feature/fix? When the VPC endpoints and the private subnets were removed here #3607, the Timer was still using the SubnetPrivateX in the VPC config, which was blocking any attempt on updating any rack with Timers.  Since the Timers don't use the private subnet anymore, is safe to remove them if the rack is not private. ### Does it has a breaking change? For old racks before `20221202145130` with Timers deployed, they will receive an error while updating the rack (due to the removal of the private subnet). The user must update to `20221202145130`, deploy the Timer again, and then update the rack. ### How to use/test it? Update any rack to the RC, after the update is complete, check on VPC if the private subnet was deleted. For private racks, the private subnet should still exist. ### Checklist - [ ] New coverage tests - [x] Unit tests passing - [x] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [x] No warnings or errors on Deepsource/Codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
When the VPC endpoints and the private subnets were removed here #3607, the Timer was still using the SubnetPrivateX in the VPC config, which was blocking any attempt on updating any rack with Timers.
Since the Timers don't use the private subnet anymore, is safe to remove them if the rack is not private.
Does it has a breaking change?
For old racks before
20221202145130with Timers deployed, they will receive an error while updating the rack (due to the removal of the private subnet). The user must update to20221202145130, deploy the Timer again, and then update the rack.How to use/test it?
Update any rack to the RC, after the update is complete, check on VPC if the private subnet was deleted. For private racks, the private subnet should still exist.
Checklist