Skip to content

Commit

Permalink
LayoutMedia: Should not handle OOF boxes
Browse files Browse the repository at this point in the history
After LayoutMediaNGContainer task, LayoutMedia could be a container of
its OOF descendants, but NGReplacedLayoutAlgorithm has no ability to lay
out OOF boxes.

This CL fixes the issue by making LayoutMedia children OOF containers
by forcing paint containment.

Bug: 1425520
Change-Id: I19e10c9a94341cba376883bf544ef69ea413dca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4349736
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119211}
  • Loading branch information
tkent-google authored and cookiecrook committed Mar 21, 2023
1 parent 0a9633d commit efde5de
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<!DOCTYPE html>
<html lang="en" class="reftest-wait">
<style>
video { width:560px; height:320px; }
</style>
<video>
<source src="/media/white.webm" type="video/webm">
<source src="/media/white.mp4" type="video/mp4">
<track label="English subtitles" kind="subtitles" srclang="en" src="support/test.vtt" default>
</video>
<script>
const v = document.querySelector('video');
v.onseeked = () => { document.documentElement.classList.remove('reftest-wait'); };
v.currentTime = 3;
</script>
</html>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!DOCTYPE html>
<html lang="en" class="reftest-wait">
<title>position:fixed on non-standard ::-webkit-media-text-track-display should not affect</title>
<link rel="match" href="non-standard-pseudo-elements-ref.html">
<style>
video { width:560px; height:320px; }
video::-webkit-media-text-track-display {
position: fixed !important;
}
</style>
<video>
<source src="/media/white.webm" type="video/webm">
<source src="/media/white.mp4" type="video/mp4">
<track label="English subtitles" kind="subtitles" srclang="en" src="support/test.vtt" default>
</video>
<script>
const v = document.querySelector('video');
v.onseeked = () => { document.documentElement.classList.remove('reftest-wait'); };
v.currentTime = 3;
</script>
</html>

0 comments on commit efde5de

Please sign in to comment.