DEBUG TOOLBAR - fix INTERNAL_IPS discovery for docker #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, for IP ex: 172.19.0.13 becomes: 172.19.0.11 now, it becomes 172.19.0.1
dudanogueira
changed the title
|
Thanks for the fix 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix for the INTERNAL_IPS when using DOCKER
Rationale
For users with multiple containers, the DEBUG TOOL BAR stops showing up if the django container receives an IP higher than 9, ex 172.19.0.10, it becomes 172.19.0.11, not complying with the INTERNAL_IPS requirement.
The actual code doesn't consider this scenario. This fix will work for all scenarios.
Use case(s) / visualization(s)
Users that has a stack with numerous containers