Improve the ROOT_DIR definition #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should |
By consistency, I think so |
and raise an error if the path does not exist by using the "resolve" method. Use "parent.parent.parent" instead of "parents[2]"
luzfcb
force-pushed
the
ensure-absolute-path
branch
from
a8ba3e2
to
1247f06
Compare
|
Added fixes for |
browniebroke
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ROOT_DIR, and raise an error if the path does not exist by using theresolvemethod. https://docs.python.org/3/library/pathlib.html#pathlib.Path.resolveparent.parent.parentbecause "Explicit is better than implicit" and because it causes less cognitive overload thatparents[2].Rationale
A similar change will be sent when django 3.1 is released.