Feature/add missing migrations file check #4973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnav13081994
force-pushed
the
feature/add_missing_migrations_file_check
branch
from
89f3875
to
7d8bf4e
Compare
browniebroke
reviewed
Apr 6, 2024
There was a problem hiding this comment.
I'm -1 on this. I don't think pre-commit is the right place to check for that.
Also, from the template maintenance perspective, this file if free of templating logic, which enable us to run pre-commit autoupdate to keep versions up to date. Accepting this PR would break this workflow. I think the trade-off is not worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a local pre-commit hook that fails in case the user forgot to commit a migration file.
Checklist:
Rationale