Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace WIP PRs with draft PRs #39

Merged
merged 2 commits into from
May 10, 2019
Merged

Conversation

balvig
Copy link
Contributor

@balvig balvig commented Apr 26, 2019

Replaces our [WIP] PR Title approach with using actual draft pull requests.
Companion to https://github.com/cookpad/cp8/pull/84.

@balvig balvig force-pushed the jb/replace-wip-prs-with-draft-prs branch from 83ccba8 to 3123279 Compare April 26, 2019 07:38
@balvig balvig force-pushed the jb/replace-wip-prs-with-draft-prs branch from 3123279 to af96466 Compare April 26, 2019 08:05
Copy link
Contributor

@sogamoso sogamoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! Good to be able the some of the new GH features.

body
body,
draft: true,
accept: "application/vnd.github.shadow-cat-preview" # waiting for https://github.com/octokit/octokit.rb/pull/1114
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove this now, seems like octokit/octokit.rb#1114 was already merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will take a look in a subsequent PR.

body: "Closes balvig/cp8_cli#ISSUE_NUMBER\n\n_Release note: ISSUE TITLE_",
draft: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@lewispb lewispb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@balvig
Copy link
Contributor Author

balvig commented May 10, 2019

Merging, but will test locally for a bit before releasing a new gem.

@balvig balvig merged commit 5d96352 into master May 10, 2019
@balvig balvig deleted the jb/replace-wip-prs-with-draft-prs branch May 10, 2019 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants