Introduce rspec rubocop #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejanium
approved these changes
Nov 4, 2022
https://docs.rubocop.org/rubocop/configuration.html#generic-configuration-parameters |
|
Ah nice, I thought it was never implemented rubocop/rubocop#1918 (comment) |
|
I checked it works on global-web by fetching via inherit_from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Introduces rspec rubocop
Why
In
global-web, we disabled rspec rubocop. However, in some cases we would like to point out our coding rule violation. So I add rpsec rubocop.https://github.com/cookpad/global-web/pull/33185
How
I just added one rule as a first step.
https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClass
global-style-guides/.rubocop.rspec.yml
Lines 51 to 52 in 028a31d