fix: remove srcObject attribute if next uri is not a MediaStream (#1121)

cookpete · Jan 20, 2021 · 7e69418 · 7e69418
1 parent ffdd813
commit 7e69418
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/players/FilePlayer.js b/src/players/FilePlayer.js
@@ -33,6 +33,13 @@ export default class FilePlayer extends Component {
       this.removeListeners(this.prevPlayer, prevProps.url)
       this.addListeners(this.player)
     }
+
+    if (
+      this.props.url !== prevProps.url &&
+      !isMediaStream(this.props.url)
+    ) {
+      this.player.removeAttribute('srcObject')
+    }
   }
 
   componentWillUnmount () {

diff --git a/test/players/FilePlayer.js b/test/players/FilePlayer.js
@@ -393,3 +393,13 @@ test('auto width/height', t => {
     </video>
   ))
 })
+
+test('clear srcObject on url change', t => {
+  const url = new MockMediaStream()
+  const wrapper = shallow(<FilePlayer url={url} config={config} />)
+  const instance = wrapper.instance()
+  instance.player.removeAttribute = sinon.fake()
+  instance.load(url)
+  wrapper.setProps({ url: 'file.mpv' })
+  t.true(instance.player.removeAttribute.calledOnceWith('srcObject'))
+})