Remove legacy config props

Breaking changes:
- Legacy config props will no longer work

README.md

@@ -118,16 +118,6 @@ There is a single `config` prop to override settings for each type of player:
 />
 ```
 
-The old style [config props](https://github.com/CookPete/react-player/tree/v0.23.0#config-props) still work but will produce a console warning:
-
-```jsx
-<ReactPlayer
-  url={url}
-  youtubeConfig={{ playerVars: { showinfo: 1 } }}
-  facebookConfig={{ appId: '12345' }}
-/>
-```
-
 Settings for each player live under different keys:
 
 Key | Options
@@ -297,7 +287,7 @@ You can also specify a `type` for each source by using objects with `src` and `t
 />
 ```
 
-[`<track>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/track) elements for subtitles can be added using `fileConfig`:
+[`<track>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/track) elements for subtitles can be added using `config.file`:
 
 ```jsx
 <ReactPlayer

index.d.ts

@@ -89,13 +89,6 @@ export interface ReactPlayerProps {
   light?: boolean | string;
   wrapper?: any;
   config?: Config;
-  soundcloudConfig?: SoundCloudConfig;
-  youtubeConfig?: YouTubeConfig;
-  facebookConfig?: FacebookConfig;
-  dailymotionConfig?: DailyMotionConfig;
-  vimeoConfig?: VimeoConfig;
-  fileConfig?: FileConfig;
-  wistiaConfig?: WistiaConfig;
   onReady?(): void;
   onStart?(): void;
   onPlay?(): void;

src/ReactPlayer.js

@@ -1,7 +1,8 @@
 import React, { Component, Suspense, lazy } from 'react'
+import merge from 'deepmerge'
 
-import { propTypes, defaultProps, DEPRECATED_CONFIG_PROPS } from './props'
-import { getConfig, omit, isEqual } from './utils'
+import { propTypes, defaultProps } from './props'
+import { omit, isEqual } from './utils'
 import players from './players'
 import Player from './Player'
 
@@ -11,6 +12,8 @@ const Preview = lazy(() => import('./Preview'))
 const SUPPORTED_PROPS = Object.keys(propTypes)
 let customPlayers = []
 
+const getConfig = props => merge(defaultProps.config, props.config)
+
 export default class ReactPlayer extends Component {
   static displayName = 'ReactPlayer'
   static propTypes = propTypes
@@ -42,7 +45,7 @@ export default class ReactPlayer extends Component {
     return false
   }
 
-  config = getConfig(this.props, defaultProps, true)
+  config = getConfig(this.props)
   state = {
     showPreview: !!this.props.light
   }
@@ -60,7 +63,7 @@ export default class ReactPlayer extends Component {
 
   componentDidUpdate (prevProps) {
     const { light } = this.props
-    this.config = getConfig(this.props, defaultProps)
+    this.config = getConfig(this.props)
     if (!prevProps.light && light) {
       this.setState({ showPreview: true })
     }
@@ -141,7 +144,7 @@ export default class ReactPlayer extends Component {
   render () {
     const { url, style, width, height, light, playIcon, wrapper: Wrapper } = this.props
     const showPreview = this.state.showPreview && url
-    const otherProps = omit(this.props, SUPPORTED_PROPS, DEPRECATED_CONFIG_PROPS)
+    const otherProps = omit(this.props, SUPPORTED_PROPS)
     const activePlayer = this.getActivePlayer(url)
     const player = this.renderActivePlayer(url, activePlayer)
     const preview = <Preview url={url} light={light} playIcon={playIcon} onClick={this.handleClickPreview} />

src/props.js

@@ -179,13 +179,3 @@ export const defaultProps = {
   onEnablePIP: function () {},
   onDisablePIP: function () {}
 }
-
-export const DEPRECATED_CONFIG_PROPS = [
-  'soundcloudConfig',
-  'youtubeConfig',
-  'facebookConfig',
-  'dailymotionConfig',
-  'vimeoConfig',
-  'fileConfig',
-  'wistiaConfig'
-]

src/utils.js

@@ -2,8 +2,6 @@ import { isValidElement } from 'react'
 import loadScript from 'load-script'
 import merge from 'deepmerge'
 
-import { DEPRECATED_CONFIG_PROPS } from './props'
-
 const MATCH_START_QUERY = /[?&#](?:start|t)=([0-9hms]+)/
 const MATCH_END_QUERY = /[?&#]end=([0-9hms]+)/
 const MATCH_START_STAMP = /(\d+)(h|m|s)/g
@@ -97,20 +95,8 @@ export function getSDK (url, sdkGlobal, sdkReady = null, isLoaded = () => true,
   })
 }
 
-export function getConfig (props, defaultProps, showWarning) {
-  let config = merge(defaultProps.config, props.config)
-  for (const p of DEPRECATED_CONFIG_PROPS) {
-    if (props[p]) {
-      const key = p.replace(/Config$/, '')
-      config = merge(config, { [key]: props[p] })
-      if (showWarning) {
-        const link = 'https://github.com/CookPete/react-player#config-prop'
-        const message = `ReactPlayer: %c${p} %cis deprecated, please use the config prop instead – ${link}`
-        console.warn(message, 'font-weight: bold', '')
-      }
-    }
-  }
-  return config
+export function getConfig (props, defaultProps) {
+  return merge(defaultProps.config, props.config)
 }
 
 export function omit (object, ...arrays) {

test/ReactPlayer/props.js

@@ -35,15 +35,6 @@ test('progressFrequency warning', t => {
   stub.restore()
 })
 
-test('config - deprecated config', t => {
-  const stub = sinon.stub(console, 'warn')
-  const youtubeConfig = { playerVars: { showinfo: 1 } }
-  const wrapper = shallow(<ReactPlayer youtubeConfig={youtubeConfig} />)
-  t.true(wrapper.instance().config.youtube.playerVars.showinfo === 1)
-  t.true(stub.calledOnce)
-  stub.restore()
-})
-
 test('config - updates', t => {
   const config = { youtube: { playerVars: { showinfo: 1 } } }
   const wrapper = shallow(<ReactPlayer config={config} />)