-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding any events in youtube embedOptions stops the Player onReady event from ever triggering #1016
Comments
What events are you using, out of curiosity? I think most, if not all, are covered by other ReactPlayer props. |
|
What state change are you listening for? The logic here covers every type, I think? |
fair enough, I guess I can work around using the youtube player events, thanks. (I would still recommend to either not allow |
I'm going to add a console warning when |
Current Behavior
Youtube embedOptions are completely overwritten with the config value ( src )
causing this handler to never run.
the ready handler never running stops a couple things from working, one of them is changing the url (I've ran into this warning, though this particular problem can be circumvented by setting the url to empty first, and then to the new value), and the progress update won't fire either.
Expected Behavior
both the event handlers passed in through the props, and the event handlers added in the
Youtube
class are classedThe text was updated successfully, but these errors were encountered: