Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If I enter a full youtube URL copied from the address bar then it doesn't play. #1088

Closed
sambhav-gore opened this issue Nov 22, 2020 · 5 comments

Comments

@sambhav-gore
Copy link

Be sure to search for your issue before opening a new one.

Current Behavior

I have made a minimum reproduction here - https://codesandbox.io/s/react-player-youtube-wedji

If I enter a URL by directly copying from the browser, example: https://www.youtube.com/watch?v=Qtb11P1FWnc&ab_channel=Coldplay then it does not play.

Removing the ab_channel param makes it work.

However it does play correctly in the demo, so I am wondering how can I enable that in my app?

Expected Behavior

Directly copying the URL from youtube should work.

Steps to Reproduce

  1. Please see the minimal reproduction at https://codesandbox.io/s/react-player-youtube-wedji

Environment

Other Information

Does play correctly in the demo.

@cookpete
Copy link
Owner

Good spot! The updated regex for parsing the channel= param is incorrectly picking up ab_channel= too.

@michelecocuccio
Copy link

michelecocuccio commented Dec 8, 2020

@cookpete hello. Is there a plan to fix this soon? Do you have a time frame for the next release with this fix?

Thanks

@cookpete
Copy link
Owner

cookpete commented Dec 8, 2020

Is there a plan to fix this soon? Do you have a time frame for the next release with this fix?

I have a fix. I’ll publish a release in the next couple of days.

@michelecocuccio
Copy link

Thanks for the prompt reply @cookpete. Keep the good work 👍

@arjdesign
Copy link

I am still getting this issue. I was wondering if it has been fixed?

Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
philip-luther added a commit to philip-luther/react-player that referenced this issue Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants