Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Direct links from vimeo is not working #1399

Closed
mayander30 opened this issue Feb 10, 2022 · 21 comments
Closed

New Direct links from vimeo is not working #1399

mayander30 opened this issue Feb 10, 2022 · 21 comments

Comments

@mayander30
Copy link

Vimeo changed the direct links from the api now returns like it

https://player.vimeo.com/progressive_redirect/playback/675622290/rendition/360p?loc=external&oauth2_token_id=1406393538&signature=1545279f8150f119095ae76eb3326158500e1a9f3b2df1ed271917f4e3d0af2d

this links works fine in a

@stanimal
Copy link

stanimal commented Feb 14, 2022

I'm seeing the same issue. React player is trying to load the new url format with the oembed Vimeo API, which is returning a 404. With the old format vimeo urls, React player does not try to load via oembed.

@Fyb3roptik
Copy link

Same issue here!

@Fyb3roptik
Copy link

@cookpete This is affecting my prod env

@mayander30
Copy link
Author

Yes, me too, I am using the embed link, but is not the solution for me, maybe we need use other lib.

@Fyb3roptik
Copy link

Let me know if you find one

@cookpete
Copy link
Owner

This is only broken because Vimeo have decided not to include .mp4 or some other sensible extension in their links to external video files. Very annoying. Publishing a fix shortly.

@garciabruno
Copy link

Any updates on this?

@cookpete
Copy link
Owner

I’m publishing a new version soon that includes a fix for this (plus loads of other recent fixes).

@aaronetales
Copy link

@cookpete Do you have an estimate as to the release to the master branch?

@Fyb3roptik
Copy link

I already removed this component as I cannot afford for this to happen again.

@iiKulakov
Copy link

Same issue, waiting for update...

@Fyb3roptik
Copy link

Workaround is to manually add video like so

<video
     width="100%" height="100%"
     controls={true}
     autoPlay
     src={videoUrl} />

@dohomi
Copy link

dohomi commented Mar 16, 2022

I receive following error on Vimeo videos, is that related? Vimeo videos are not loading at all while Youtube works.

next-dev.js?3515:32 TypeError: t.replace is not a function
    at u (player.js:2:1049)
    at player.js:2:10858
    at new Promise (<anonymous>)
    at new Player (player.js:2:10370)

@Fyb3roptik
Copy link

I receive following error on Vimeo videos, is that related? Vimeo videos are not loading at all while Youtube works.

next-dev.js?3515:32 TypeError: t.replace is not a function
    at u (player.js:2:1049)
    at player.js:2:10858
    at new Promise (<anonymous>)
    at new Player (player.js:2:10370)

Yes

@mayander30
Copy link
Author

@cookpete Any chance to solve this issue ?

@dohomi
Copy link

dohomi commented Mar 17, 2022

is there a workaround at the moment?

@Fyb3roptik
Copy link

Workaround is to manually add video like so

<video
     width="100%" height="100%"
     controls={true}
     autoPlay
     src={videoUrl} />

@dohomi I posted one above

@cookpete
Copy link
Owner

Fixed in 2.10.0. Sorry for the delay all.

@LC43
Copy link

LC43 commented Mar 19, 2022

thank you for your hard work @cookpete !

@keerthiyml
Copy link

Facing this issue again. However vimeo videos work locally but not in any environments. Any suggestions?

@Fyb3roptik
Copy link

Workaround is to manually add video like so

<video
     width="100%" height="100%"
     controls={true}
     autoPlay
     src={videoUrl} />

@keerthiyml

philip-luther added a commit to philip-luther/react-player that referenced this issue Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants