-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Direct links from vimeo is not working #1399
Comments
I'm seeing the same issue. React player is trying to load the new url format with the oembed Vimeo API, which is returning a 404. With the old format vimeo urls, React player does not try to load via oembed. |
Same issue here! |
@cookpete This is affecting my prod env |
Yes, me too, I am using the embed link, but is not the solution for me, maybe we need use other lib. |
Let me know if you find one |
This is only broken because Vimeo have decided not to include |
Any updates on this? |
I’m publishing a new version soon that includes a fix for this (plus loads of other recent fixes). |
@cookpete Do you have an estimate as to the release to the master branch? |
I already removed this component as I cannot afford for this to happen again. |
Same issue, waiting for update... |
Workaround is to manually add video like so
|
I receive following error on Vimeo videos, is that related? Vimeo videos are not loading at all while Youtube works. next-dev.js?3515:32 TypeError: t.replace is not a function
at u (player.js:2:1049)
at player.js:2:10858
at new Promise (<anonymous>)
at new Player (player.js:2:10370) |
Yes |
@cookpete Any chance to solve this issue ? |
is there a workaround at the moment? |
@dohomi I posted one above |
Fixed in |
thank you for your hard work @cookpete ! |
Facing this issue again. However vimeo videos work locally but not in any environments. Any suggestions? |
|
Hopefully fixes cookpete/react-player#1399
Vimeo changed the direct links from the api now returns like it
https://player.vimeo.com/progressive_redirect/playback/675622290/rendition/360p?loc=external&oauth2_token_id=1406393538&signature=1545279f8150f119095ae76eb3326158500e1a9f3b2df1ed271917f4e3d0af2d
this links works fine in a
The text was updated successfully, but these errors were encountered: