Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add title attribute to vimeo iframe #1229

Merged

Conversation

danhemerlein
Copy link
Contributor

This adds title as a supported prop for <ReactPlayer />. When <ReactPlayer /> is a <Vimeo /> component that title will appear as a title attribute on the iframe within the container.

Having a title attribute on an iframe is critical for screen reader users to tell them what is contained within that element.

more info on this topic from W3 can be found here

@cookpete
Copy link
Owner

Updated to move title into the Vimeo config prop to not pollute the top level props.

@cookpete cookpete merged commit e3c324b into cookpete:master Oct 26, 2021
@cookpete
Copy link
Owner

Published in 2.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants