Add oEmbedUrl as changeable prop #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tweaked it a bit so you’ll have to do Nice work! |
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to use another service for retrieving the preview image.
I tested the code by adding this property to
ReactPlayerin App.js:Noembed doesn't seem to be maintained anymore and there is no purge cache support and the default cache is set to expire after 100 days.
I started a new oEmbed service with purge support over at https://github.com/playerxo/oembed
It's hosted on Cloudflare workers which offers a generous free tier and it's written in Javascript.
Feel free to use it or host your own with the pubic code.