Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes in FacebookConfig type #1351

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Conversation

Awkk
Copy link
Contributor

@Awkk Awkk commented Nov 10, 2021

Fix for the below issue when using react-player facebook config in typescript

Current Behavior

  • Using react-player with typescript
  • Typescript flags it as an error if try to pass attributes to FacebookConfig

Expected Behavior

Should be able to configure as below

<ReactPlayer
  url={url}
  config={{
    facebook: {
      attributes: {
        height: "480px"
    }
  }}
/>

@azaareer93
Copy link

when will this fix going to be available ?

@cookpete cookpete merged commit 91a9e0e into cookpete:master Feb 19, 2022
@lukasztucholski
Copy link

Bump - can someone fix build?

@cookpete
Copy link
Owner

Published in 2.10.0. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants