Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typings for onProgress callback #246

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Update typings for onProgress callback #246

merged 1 commit into from
Oct 13, 2017

Conversation

vickychijwani
Copy link
Contributor

@vickychijwani vickychijwani commented Oct 8, 2017 •
edited
Loading

Hi! The onProgress callback is incompletely specified in index.d.ts - according to the README it also receives playedSeconds and loadedSeconds, but they're not mentioned in the Typescript definition file. This PR adds them.

@cookpete cookpete merged commit 5b5df11 into cookpete:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vickychijwani @cookpete