Fix Vimeo link validation. #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests were failing because your implmentation broke the URL switching logic when the Vimeo player was already loaded. A numeric video ID was required for loading a new video into an existing player. As of |
|
It's super weird. Locally tests were passing. Error in Travis Ci occurred in different place in one of the test runs. |
Yeah.. #332 (comment) |
david-hub024
pushed a commit
to david-hub024/React_VideoPlayer
that referenced
this pull request
Dec 23, 2018
david-hub024
pushed a commit
to david-hub024/React_VideoPlayer
that referenced
this pull request
May 23, 2020
albanqoku
added a commit
to albanqoku/react-player
that referenced
this pull request
Feb 24, 2021
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this pull request
May 20, 2021
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this pull request
Sep 9, 2022
philip-luther
added a commit
to philip-luther/react-player
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue, when using player with some of Vimeo links.
Sharing this video https://vimeo.com/249675407 using Vimeo's share button generates link as follows: https://vimeo.com/yannickcerrutti/annecydroneinmotion. Such link isn't treated as Vimeo's, but it should be. I propose simplifying regex - there is no need for such complexity due to of possible variations of links.
I've also spotted corrupted file link which I've replaced with working one so that test would pass again.