Accept youtube.com/playlist?list= URLs #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassaans
approved these changes
Jan 1, 2019
The only reason for the current regex pattern is to extract the video ID here when firing up a player. However, now we have playlist parsing, the I'm not overly happy with how complex this has become, but your change is harmless enough and enables proper playlist support. I'll have a look at tidying things up later on. |
albanqoku
added a commit
to albanqoku/react-player
that referenced
this pull request
Feb 24, 2021
Follow up to cookpete/react-player#541
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this pull request
May 20, 2021
Follow up to cookpete/react-player#541
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this pull request
Sep 9, 2022
Follow up to cookpete/react-player#541
philip-luther
added a commit
to philip-luther/react-player
that referenced
this pull request
Nov 22, 2024
Follow up to cookpete/react-player#541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow react-player to play URLs like https://www.youtube.com/playlist?list=PLDEcUiPhzbjI217qs5KgMvbvx6-fgY_Al. I'm not sure on the policy here ― should it play only those links that are "supposed" to be played (those that are "shareable" and have
v=parameter) vs should it play anything that was dropped on it if it can (even if the user copied "wrong" playlist URL)?