Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented onBufferEnd cb prop for FilePlayer, YouTube and Facebook #615

Merged
merged 9 commits into from
Apr 10, 2019

Conversation

me-andre
Copy link
Contributor

@me-andre me-andre commented Apr 4, 2019

No description provided.

README.md Outdated Show resolved Hide resolved
@cookpete
Copy link
Owner

cookpete commented Apr 5, 2019

One suggested tweak to the readme, and onBufferEnd needs to be added to index.d.ts, but otherwise I think we are good 👍

cookpete and others added 2 commits April 10, 2019 10:46
@me-andre
Copy link
Contributor Author

done :)

@cookpete cookpete merged commit e4450bc into cookpete:master Apr 10, 2019
@cookpete
Copy link
Owner

Nice work 👍 Apologies for the delay.

@me-andre me-andre deleted the on_buffer_end branch April 15, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants