Properly delete SDK requests #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We test for 'requests[url]' which is true for an empty array, so reset it to null after a failed fetch.
As we use shared global variables in getSDK the tests can't be run concurrently, which is the default for AVA.
|
Nice work 👍 I think I was trying to be too clever when trying to avoid the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes of #711 don't have an effect as
requests[url]is set to an empty array after a failed fetch which evaluates totruefor all following fetches. It has to be set to something evaluating tofalseinstead. I added a test for the scenario.Additionally, I activated the other getSDK tests. As getSDK() uses global variables, the tests have to be serial.