Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to set the custom facebook version #745

Merged
merged 3 commits into from
Nov 20, 2019

Conversation

HsuTing
Copy link
Contributor

@HsuTing HsuTing commented Nov 13, 2019

The new version of the facebook version is v3.3. I would like to have a new config to set the facebook version. In my website, react-player will overwrite my facebook version. As a result, I can not use facebook login in my website.

src/props.js Outdated Show resolved Hide resolved
@HsuTing
Copy link
Contributor Author

HsuTing commented Nov 19, 2019

Hi @cookpete . Does this pr have any problem?
I hope this pr can be merged and released ASAP.

@cookpete cookpete merged commit b7b2b1c into cookpete:master Nov 20, 2019
@cookpete
Copy link
Owner

Published in react-player@1.14.2. Thanks @HsuTing !

@HsuTing HsuTing deleted the support-custom-version branch November 21, 2019 00:52
@HsuTing
Copy link
Contributor Author

HsuTing commented Nov 21, 2019

Thank you! 👍

Copy link

@salemwosabi salemwosabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load plans not working

@HsuTing
Copy link
Contributor Author

HsuTing commented Dec 19, 2019

load plans not working

Can you give me the example or a reproduced repo ?
Maybe I can help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants