Add unique wistia player id to have possibility to have multiple players with the same url on one page #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbogretsov
approved these changes
May 31, 2020
afzaalahmad
reviewed
Jun 11, 2020
| @@ -24,7 +26,7 @@ export default class Wistia extends Component { | |||
| getSDK(SDK_URL, SDK_GLOBAL).then(() => { | |||
| window._wq = window._wq || [] | |||
| window._wq.push({ | |||
| id: this.getID(url), | |||
| id: this.playerID, | |||
There was a problem hiding this comment.
can we do something like this here:
id: this.props.id || this.playerID
afzaalahmad
reviewed
Jun 11, 2020
src/players/Wistia.js
Outdated
| @@ -111,7 +113,7 @@ export default class Wistia extends Component { | |||
| height: '100%' | |||
| } | |||
| return ( | |||
| <div key={id} className={className} style={style} /> | |||
| <div id={this.playerID} key={id} className={className} style={style} /> | |||
There was a problem hiding this comment.
same goes here:
id={this.props.id || this.playerID}
…ers with the same url on one page
cookpete
force-pushed
the
multiple-videos-with-same-url
branch
from
7559098 to
916fd85
Compare
|
I've added a |
|
@cookpete appreciated 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #623
Tested on the page with two Wistia players with the same URL and they don't affect each other anymore.