Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: fix stray \ warnings with grep-3.8 #10198

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

misaka36
Copy link
Contributor

Build system: Ubuntu 20.04.5 x86_64 with grep-3.8
Build-tested: ipq807x/QNAP_301w
Q:你知道这是pull request吗?(使用 "x" 选择)

  • 我知道

neheb and others added 3 commits September 29, 2022 21:08
head is not necessary here.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
We simply grep for "/usr". So no need for "-E" or "\/". Furthermore, in
the new grep versions this creates warnings.

As written in the grep-3.8 announcement:
  Regular expressions with stray backslashes now cause warnings, as
  their unspecified behavior can lead to unexpected results.
  For example, '\a' and 'a' are not always equivalent
  <https://bugs.gnu.org/39678>.

Fixes warnings in the form of:
  grep: warning: stray \ before /

Signed-off-by: Nick Hainke <vincent@systemli.org>
Fixes build warnings when using newer versions of grep.

Signed-off-by: Chris Osgood <chris_github@functionalfuture.com>
Tested-by: Georgi Valkov <gvalkov@gmail.com>
@aiamadeus aiamadeus merged commit e56df4c into coolsnowwolf:master Sep 30, 2022
@misaka36 misaka36 deleted the fix-grep branch September 30, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants