Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New address parameter #3481

Merged
merged 11 commits into from
Dec 7, 2022
Merged

New address parameter #3481

merged 11 commits into from
Dec 7, 2022

Conversation

lucasferraro
Copy link
Contributor

@lucasferraro

This comment was marked as resolved.

Sign in to view
@amonxnye amonxnye mentioned this pull request Nov 21, 2022
Open
@alexsegura

This comment was marked as resolved.

Sign in to view
@alexsegura
Copy link
Member

@lucasferraro

In homepage now the user is not able to enter to a restaurant page because if there isn't an address selected we'll ask for an address preventing the navigation to restaurant page. And when user enters an address, we automatically navigate to shops page, only in this page the user is able to click on a restaurant and navigate to its page.

Yes, it's quite confusing. Can we use applyClickListenerForRestaurantItem only on the list page?

@alexsegura

This comment was marked as resolved.

Sign in to view
@alexsegura alexsegura merged commit 66592f0 into master Dec 7, 2022
@alexsegura alexsegura deleted the new_address_parameter branch December 7, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsegura alexsegura alexsegura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not trust session storage for address search
2 participants
@lucasferraro @alexsegura